Re: HawkNL 1.68 fixes for OS X 10.4

Posted by Emanuel Zephir on April 04, 2006 at 00:34:10:

In Reply to: Re: HawkNL 1.68 fixes for OS X 10.4 posted by Kristleifur Da�ason on March 03, 2006 at 12:39:00:

: Oh, there's also a change in loopback.c -- loopback_getNextPort.
:
: Line:
: if(++newport > 65535)
:
: What if newport overflows?
:
: If i'm not wrong, it could be like this:
: if(++newport > 65535 || newport < 1024)

Actually, I think that line would be correctly written as
if (++newport == 0 || newport < 1024)...
Since when newport overflows, it should become 0 (all the 1s carry). However, a better option in my opinion, would be to remove the ++ :-)